-
-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document Polyhedron defined over number field #17197
Comments
comment:1
With 6.4.beta6 I get
|
comment:2
Though the original example fails:
Slightly simpler failure:
|
comment:3
This originates at the following comparison:
|
comment:4
Thanks for tracking this down. Should I file a separate ticket for this under the number theory? |
comment:5
You can just change the description and use this ticket. I think we agree that this is not a bug in polyhedra. See also the discussion on sage-devel. |
This comment has been minimized.
This comment has been minimized.
comment:8
All of these tests in description and comments seem to working in 7.3.beta9. |
comment:9
yes because comparison in number fields is now working... (#17830). Instead of making it invalid, it would be much better to add doctests! |
This comment has been minimized.
This comment has been minimized.
Dependencies: #21105 |
comment:15
Since the Polyhedron evolved quite a bit in the last year, here is an update on Sage8.2.rc1:
The value error above will be changed in #24835 to a more appropriate error message, for which:
is the only way to get a symbolic expression to pass on to the constructor of Polyhedron. Concerning documenting the Polyhedron class usage through NumberFields, I believe that #22572 does the job. Hence, once #22572 is merged, I would set this ticket to won't fix: the bug is fixed. |
comment:16
An improvement of the doc is posted on #26077, where I also point out that |
comment:17
Just an update of the current situation in
and it is still possible to do:
Similar examples should now complete the docstring, now that #25097 is merged. |
As reported in this google group (https://groups.google.com/forum/#!topic/sage-support/ew0bnGzjm98), it was not possible to create Polyhedron defined over number fields. Now that #17830 is merged it does work and it should be documented and even advertised in the documentation!
from the previous report:
To create polyhedra quickly, the final suggestion in the Polyhedron documentation (http://www.sagemath.org/doc/reference/geometry/sage/geometry/polyhedron/constructor.html#base-rings) is to work in a set number field. Although this appears to work for setting vertices, it does not appear to work for lines (or rays).
For example:
This should be compared with:
and
Additionally, how can a "1-dimensional polyhedron" be "defined as the convex hull of 1 vertex and 2 rays"?
As pointed out below this is an issue with Polyhedron using a number fields < comparison
Depends on #21105
CC: @fchapoton @jplab @sagetrac-jakobkroeker
Component: number theory
Keywords: Polyhedron
Issue created by migration from https://trac.sagemath.org/ticket/17197
The text was updated successfully, but these errors were encountered: