Fix numerical_approx with algorithm keyword

[kcrisman]

This is not currently an issue since we haven't implemented it, but we should make it work. See #12289.

sage: erf(1).n(algorithm='foo')
0.842700792949715
sage: erf(0)
0
sage: parent(erf(0))
Integer Ring
sage: erf(0).n(algorithm='foo')
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)

/Users/mcneil/sagedev/sage-5.1.beta0b/sage-5.1.beta0/devel/sage-hack2/sage/<ipython console> in <module>()

/Users/mcneil/sagedev/sage-5.1.beta0b/sage-5.1.beta0/local/lib/python2.7/site-packages/sage/structure/element.so in sage.structure.element.Element.numerical_approx (sage/structure/element.c:4988)()

TypeError: numerical_approx() got an unexpected keyword argument 'algorithm'

Depends on #12289

CC: @eviatarbach

Component: symbolics

Keywords: algorithm

Author: Eviatar Bach

Branch/Commit: f9d60c8

Reviewer: Ralf Stephan

Issue created by migration from https://trac.sagemath.org/ticket/14778

[eviatarbach]

Dependencies: #12289

[eviatarbach]

comment:4

Attachment: trac14778.patch.gz

[kcrisman]

comment:5

I don't see any obvious problems with this. How did you check whether you found all possible places where numerical approximation would potentially get this keyword? Otherwise it looks good and ready to test, though patchbot hasn't gotten around to it. Not sure what the story is on that.

[eviatarbach]

comment:6

I just searched the source for _numerical_approx methods, which is what gets called when the numerical_approx function is called on an object, which is what Element uses for the numerical approximation method as well.

[rwst]

Branch: u/rws/ticket/14778

[rwst]

Commit: f9d60c8

[rwst]

Changed keywords from none to algorithm

[rwst]

comment:9

Rebased on 6.2.beta2. Everything builds and tests OK. Easy patch, positive. Hope it's OK to copy the author name from the patch.

---

New commits:

f9d60c8

Trac #14778: Fix numerical_approx with algorithm keyword

[rwst]

Author: Eviatar Bach

[rwst]

Reviewer: Ralf Stephan

[eviatarbach]

comment:10

Thanks so much for reviewing!

[vbraun]

Changed branch from u/rws/ticket/14778 to f9d60c8