Fix "except:" statements

[jdemeyer]

Replace

except:

by

except StandardError:

(or an other exception where it makes sense)

Also fix some dubious except KeyboardInterrupt which caused for example

Interrupting Gap...
Traceback (most recent call last):
  File "/home/jdemeyer/slow5.py", line 11, in <module>
    __time__=misc.cputime(); __wall__=misc.walltime(); test(); print "Time: CPU %.2f s, Wall: %.2f s"%(misc.cputime(__time__), misc.walltime(__wall__))
  File "/home/jdemeyer/slow5.py", line 9, in test
    assert G.order() == Gamma(n).index() / g.index()
  File "/usr/local/src/sage-5.7.beta1/local/lib/python2.7/site-packages/sage/groups/matrix_gps/matrix_group.py", line 415, in order
    return self.cardinality()
  File "/usr/local/src/sage-5.7.beta1/local/lib/python2.7/site-packages/sage/groups/matrix_gps/matrix_group.py", line 398, in cardinality
    g = self._gap_()
  File "/usr/local/src/sage-5.7.beta1/local/lib/python2.7/site-packages/sage/groups/matrix_gps/matrix_group.py", line 228, in _gap_
    raise NotImplementedError, "Matrix group over %s not implemented."%self.__R
NotImplementedError: Matrix group over Ring of integers modulo 2 not implemented.

or

Interrupting Gap...
Traceback (most recent call last):
  File "/home/jdemeyer/slow5.py", line 11, in <module>
    __time__=misc.cputime(); __wall__=misc.walltime(); test(); print "Time: CPU %.2f s, Wall: %.2f s"%(misc.cputime(__time__), misc.walltime(__wall__))
  File "/home/jdemeyer/slow5.py", line 9, in test
    assert G.order() == Gamma(n).index() / g.index()
  File "/usr/local/src/sage-5.7.beta1/local/lib/python2.7/site-packages/sage/groups/matrix_gps/matrix_group.py", line 415, in order
    return self.cardinality()
  File "/usr/local/src/sage-5.7.beta1/local/lib/python2.7/site-packages/sage/groups/matrix_gps/matrix_group.py", line 400, in cardinality
    return integer.Integer(gap(self).Size())
  File "/usr/local/src/sage-5.7.beta1/local/lib/python2.7/site-packages/sage/interfaces/interface.py", line 590, in __call__
    return self._obj.parent().function_call(self._name, [self._obj] + list(args), kwds)
  File "/usr/local/src/sage-5.7.beta1/local/lib/python2.7/site-packages/sage/interfaces/gap.py", line 899, in function_call
    return self.new('last')
  File "/usr/local/src/sage-5.7.beta1/local/lib/python2.7/site-packages/sage/interfaces/interface.py", line 266, in new
    return self(code)
  File "/usr/local/src/sage-5.7.beta1/local/lib/python2.7/site-packages/sage/interfaces/interface.py", line 201, in __call__
    return cls(self, x, name=name)
  File "/usr/local/src/sage-5.7.beta1/local/lib/python2.7/site-packages/sage/interfaces/expect.py", line 1285, in __init__
    raise TypeError, x
TypeError: Ctrl-c pressed while running Gap

(note the TypeError!)

Component: misc

Author: Jeroen Demeyer

Reviewer: Volker Braun

Merged: sage-5.7.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14028

[vbraun]

comment:4

Its pretty much a no-brainer. Ready for review?

[jdemeyer]

comment:5

Replying to @vbraun:

Its pretty much a no-brainer. Ready for review?

Not sure. The following is fairly reproducible when interrupting GAP:

Interrupting Gap...
Exception RuntimeError: RuntimeError('maximum recursion depth exceeded while calling a Python object',) in  ignored
Exception RuntimeError: RuntimeError('maximum recursion depth exceeded while calling a Python object',) in  ignored
Exception RuntimeError: RuntimeError('maximum recursion depth exceeded while calling a Python object',) in  ignored
[...ad infinitum...]

The backtrace at this point (thanks to #14029) is attached.

[jdemeyer]

Attachment: sage_crash_IAI1or.log

[jdemeyer]

comment:6

The problem was removing the statement

self._session_number = -1

New patch attached which should fix this. I also changed a few more instances of

except StandardError:

to

except BaseException:

in cases where the except-clause was doing cleanup + re-raise.

[jdemeyer]

Attachment: 14028_bare_except.patch.gz

[jdemeyer]

comment:7

Passes all long doctests, so ready for review.

[vbraun]

Reviewer: Volker Braun

[vbraun]

comment:8

Looks good to me.

[jdemeyer]

Merged: sage-5.7.beta2