-
-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade polymake to version 2.12-rc3 #13768
Comments
Changed dependencies from 13767 to #13767 |
comment:3
Does this fix #5488 as well? |
comment:4
Yes it does. |
comment:5
I updated this to polymake-2.12 (which is bit-for-bit identical to polymake-2.12-rc3). I fixed a version number typo in SPKG.txt and updated it to reflect the rename boost-cropped -> boost_cropped. I also removed the disabling of parallel build. The polymake documentation now recommends using parallel build, so there shouldn't be any need for that anymore: The current package has md5sum 51d3b6da0ae60ac417e418bc89da1189. |
This comment has been minimized.
This comment has been minimized.
comment:6
I guess it stays experimental for now - here's the message on a Mac OS X 10.7. We explicitly do NOT want Fink as a prereq. Does anybody even still use Fink? ;-)
That said, we could probably get around that by hacking their installation procedure, especially since http://polymake.mathematik.tu-darmstadt.de/doku.php/mac apparently doesn't exist. In fact, http://polymake.mathematik.tu-darmstadt.de/doku.php/howto/mac (do you want to report that upstream?) says that
is supported, if you have java (?!?!?!) Anyway, I don't care about this for experimental, but at least one person I know who was VERY interested in using polymake through Sage uses Mac. Reading through their stuff, they just need a real gcc (not the Apple compiler on modern ones), which we provide, and perl, which is a prereq for Sage. See without fink for a full list of prereqs, which I think we include - including, soon, the full Boost headers - and some compiling options. Timo, if you aren't interested in doing this :-) then perhaps you can open a ticket with some of this information for moving polymake to an optional spkg. |
comment:7
Replying to @kcrisman:
From quickly browsing the sources, it seems possible that this would compile without issue if we call
Could you try this in a sage shell:
in a sage installation containing the boost_cropped package from #13767?
I don't have access to a Mac, but if the above naive attempt works, I'll update the spkg. (I would be willing to do some more investigation if someone could give me ssh access to OSX.) |
comment:8
You mean inside of a source folder for polymake, or with respect to this spkg? Let me know and I'll try it.
I can't do that, but if you have access to the sage.math cluster, someone might be able to do so. |
comment:9
Replying to @kcrisman:
Either in a source folder for polymake, or in the |
comment:10
After then doing
But I have a feeling that all this is actually not that hard to fix. |
comment:11
See for instance here, though I couldn't actually apply the patch, so maybe it's been incorporated already... which means I have a different problem? Or is it the whole missing the perl module thing? |
comment:12
I'm wondering also about this in spkg-install
should we add I tried to add the appropriate Perl modules for this but found some trouble - as well as noted that the specific versions of the xml thing mentioned aren't even available at CPAN... |
comment:13
Replying to @kcrisman:
That probably makes sense.
This sounds like something that upstream could be contacted about. Looking back at:
This bothers me. Why does it use a system-wide install in I have a hunch that the root of the trouble on OSX may be that the configure script uses the perl variable |
comment:14
Ok.
Yes, and the bad error message about the Mac page.
That's because I just did
I have no idea, but you may be right. |
comment:15
Replying to @kcrisman:
I see. Could you test the following in a sage shell (
and see whether it works? Because it sounds like the prefix wasn't set correctly, and I'm not sure whether that could give problems. There should be no need to use |
comment:16
Well, everything is fine except
So we definitely need this Perl package. And I'm having trouble installing it, I think because of it downloading a version for Mac but needing a linux one or something, as you suggest.
I think we need to pass the Sage gcc to this. But it's not clear to me from reading some stuff online whether one would even be able to use the Sage gcc with the local perl (compiled, perhaps, by llvm-gcc...). I tried a lot of stuff but I have a feeling that there is no real solution to this. |
comment:17
Have you tried installing that package from CPAN but from outside of the sage shell? Since we use the system's perl, we should probably also install the packages system-wide. On my Ubuntu machine, the configure script complains about the following missing perl modules:
Since polymake remains an optional package, maybe we can just require users to install these from CPAN themselves? I don't feel like adding sage's own personal perl package manager to the spkg system... As for the |
comment:18
Yes. That's the error message. But that's not the issue.
The problem is that the default libreadline on Mac is not GNU readline. See here, for example. I'm just wondering what the "right" solution is; ideally, we would use Sage's libreadline (if it were possible to pass this to the Perl package) but we need to install the Perl module before we do the Sage package compilation... chicken and the egg. I'm trying some stuff and will report back.
Probably true. But how do we disable it needing that - is there yet another configure option that would disable it? Anyway, for this ticket it would be helpful to find a way to do it with readline. |
comment:19
Replying to @kcrisman:
I think that Sage's polymake interface through pexpect (on the sage side) and readline (on the polymake side) is currently broken anyway, independent of this upgrade. IIRC, the current polymake package fails to install in recent versions of sage. And on the other hand, the new version of polymake from this ticket doesn't work with the current library code: it outputs copyright info to stderr, which sage interprets as an error having occurred. So in fact, I'm not sure if we really need to try to make the pexpect/readline interface work, when there's already efforts underway for replacing it by the shared library interface from the new version of polymake. That is to say, I'm not inclined to spend much time on that. (This is an example of a ticket needing a simultaneous change in a package and in the sage library code. For these tickets, the transition to a unified repository is very useful.)
The polymake configure script will only warn about cpan packages not being available, and it will still install without them. As long as we don't use the readline features, and as long as we ask the user to install those other packages from cpan, there is no problem. That is, if those other packages install correctly on MacOS. Do they? |
comment:20
That's fine with me, but it looked like you didn't have #14116 ready to test yet (as in having an spkg). And I'm not sure it's possible to build polymake without the readline. I couldn't find anything about that, anyway; they do have options for building without the Java viewers, but not without the command line at all. Wait, I now understand what you are saying - there will be an error and the command line version won't run (see, in fact, my comment:16) but maybe the library interface will still work. Intriguing idea. I'll check it out.
There was only one other Perl package I had to install, and
went fine (the |
comment:21
Don't forget that whatever you do here will require a slight change in spkg-install
I'm going to look at #14116 now, I'm done with this ticket for today :) |
comment:27
D'oh! The package link is broken! Timo, if you see this, please let us know where we can find it, there are a few places online we can host such things. |
This comment has been minimized.
This comment has been minimized.
comment:29
Sorry! The link works when replacing http://infty.nl by http://www.infty.nl. I updated the description. The package can be found at: |
comment:30
Trying on Mac again. First, same problem, so let's definitely change to
Probably at least Other comments:
However, perhaps all of this is superseded by the branch and new-style spkg at #14116? |
comment:31
Having had some success with #14116, I'm very much thinking this is a duplicate. |
Changed dependencies from #13767 to none |
Changed author from Timo Kluck to none |
comment:32
Yes, but setting to sage-pending in case this old-style spkg is updated with the right config. The one at #5488 is definitely superseded by this, anyway. |
comment:33
Things are looking good at #14116, so likely this will indeed end up closed - stay tuned. |
Attachment: VDelecroix-polymake-2.12.log log file of a failed installation (Linux 3.16.0-4-amd64 Debian 3.16.7-2 x86_64) |
comment:34
Moving status since nothing has happened yet. |
comment:35
New tentative at #20892 for polymake-3.0 |
comment:36
I propose to close this ticket because of #20892 |
Reviewer: Matthias Koeppe, Karl-Dieter Crisman |
comment:38
Determined to be invalid/duplicate/wontfix (closing as "wontfix" as a catch-all resolution). |
Here's an updated package for Polymake. The new package is a lot simpler than the old one, because this upstream version comes with a sane configure script and installs everything in standard locations.
This depends on the
boost-cropped
spkg >= 1.52.0This is a very long compilation. That's partly due to the fact that the
spkg-install
disables parallel build, because apparently that used to be buggy. I've been cautious and left that disabled, but I wouldn't be surprised if we could enable it again -- if the configure script has had an overhaul, then maybe so has the makefile.I'm working on a new Python interface that takes advantage of the new C++ api (via Cython) instead of writing data to a file and using
pexpect
(yuck). That'll take a while and be a different ticket.Here's the link to the new package:
http://www.infty.nl/misc/polymake-2.12.spkg
Component: packages: experimental
Reviewer: Matthias Koeppe, Karl-Dieter Crisman
Issue created by migration from https://trac.sagemath.org/ticket/13768
The text was updated successfully, but these errors were encountered: