the optional polymake doctests are seriously misformatted so never run

[williamstein]

sage: search_src('polymake')

reveals many tests marked # optional: needs polymake.
These will NOT get run by doing

sage -t -only_optional=polymake geometry/polytope.py

They should be formatted as

#optional - polymake

By the way, this test works fine without polymake is installed, because it doesn't do anything, so improve that by adding another test right after this that actually exercise the optional package.

sage: P = polymake.convex_hull([[1,0,0,0], [1,0,0,1], [1,0,1,0], [1,0,1,1],  [1,1,0,0], [1,1,0,1], [1,1,1,0], [1,1,1,1]])

Component: doctest coverage

Keywords: sd40.5

Author: Benjamin Jones

Reviewer: Mike Hansen

Merged: sage-5.1.beta3

Issue created by migration from https://trac.sagemath.org/ticket/12340

[williamstein]

comment:1

By the way, this code is from my commit 271, i.e., ancient history, before there was an infrastructure for how optional package tests worked. But it would be good to update this.

[benjaminfjones]

comment:2

I'm working on this, looks like polymake appears in geometry/polytope.py, rings/polynomial/groebner_fan.py, and rings/polynomial/multi_polynomial.pyx.

[benjaminfjones]

Attachment: trac_12340.patch.gz

mark doctests requiring polymake correctly

[benjaminfjones]

comment:3

I could add doctests to a bunch of functions here, but I can't get the the polymake spkg to build on pretty much any platform, see #5488. But in the meantime, the attached patch corrects the optional doctests.

[mwhansen]

Reviewer: Mike Hansen

[mwhansen]

Author: Benjamin Jones

[mwhansen]

comment:4

Looks good to me.

[mwhansen]

Changed keywords from none to sd40.5

[jdemeyer]

Merged: sage-5.1.beta3