mark all Lie tests as optional "requires LiE" (this is a *very* easy ticket!)

[williamstein]

Looking at the optional tests of the Lie package, shows many that aren't properly marked with "requires LiE" (and many are):

sage: search_src('optional', 'lie')
...
interfaces/lie.py:359:            sage: lie._read_info_files(use_disk_cache=False) #optional -- requires LiE
interfaces/lie.py:360:            sage: lie._trait_names_list #optional
interfaces/lie.py:504:            sage: lie.trait_names() #optional -- requires LiE
interfaces/lie.py:521:            sage: lie._an_element_impl() #optional -- requires LiE
interfaces/lie.py:533:            sage: lie.read(filename)  #optional -- requires LiE
interfaces/lie.py:534:            sage: lie.get('x')        #optional

The point of this ticket is to make them all be marked "#optional -- requires LiE". Pretty easy.

I think this ticket should get a positive review even if

  sage -t -only_optional=LiE lie.py

doesn't pass. Fixing any failures in the lie interface (if there are any) should be a separate ticket.

CC: @orlitzky

Component: doctest coverage

Keywords: sd40.5

Author: Michael Orlitzky

Reviewer: Benjamin Jones

Merged: sage-5.1.beta2

Issue created by migration from https://trac.sagemath.org/ticket/12334

[orlitzky]

comment:1

After the patch,

$ sage -t -verbose -long -optional lie.py
...
231 passed and 0 failed.

$ sage -t -verbose -long -only-optional lie.py
...
168 passed and 0 failed.

$ sage -t -verbose -long -only-optional=lie lie.py
...
168 passed and 0 failed.

[orlitzky]

Author: Michael Orlitzky

[benjaminfjones]

Reviewer: Benjamin Jones

[benjaminfjones]

Changed keywords from none to sd40.5

[benjaminfjones]

comment:3

Patch looks good and I get the same tests passed numbers as Michael at comment 1. Positive review.

[jdemeyer]

Fix optional syntax in sage/interfaces/lie.py.

[jdemeyer]

Merged: sage-5.1.beta2

[jdemeyer]

comment:4

Attachment: sage-trac_12334.patch.gz