Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional package gnuplotpy-1.8.spkg causes test failure on sage-4.7.2 #12009

Closed
sagetrac-mariah mannequin opened this issue Nov 10, 2011 · 10 comments
Closed

optional package gnuplotpy-1.8.spkg causes test failure on sage-4.7.2 #12009

sagetrac-mariah mannequin opened this issue Nov 10, 2011 · 10 comments

Comments

@sagetrac-mariah
Copy link
Mannequin

sagetrac-mariah mannequin commented Nov 10, 2011

sage-4.7.2 with the optional package gnuplotpy-1.8.spkg installed causes the following test failure:

% ./sage -t -long -force_lib "devel/sage/sage/tests/startup.py"
sage -t -long -force_lib "devel/sage/sage/tests/startup.py" 
**********************************************************************
File "/home/mariah/sage/sage-4.7.2-x86_64-Linux-core2-fc-optional/devel/sage/sage/tests/startup.py", line 13:
    sage: sage0("'numpy' in sys.modules")
Expected:
    False
Got:
    True
**********************************************************************
1 items had failures:
   1 of   5 in __main__.example_0
***Test Failed*** 1 failures.
For whitespace errors, see the file /home/mariah/.sage//tmp/startup_30568.py
         [8.0 s]
 
----------------------------------------------------------------------
The following tests failed:


        sage -t -long -force_lib "devel/sage/sage/tests/startup.py"
Total time for all tests: 8.1 seconds
%

Component: interfaces

Keywords: sd40.5

Author: Mike Hansen

Reviewer: Douglas McNeil, Karl-Dieter Crisman

Merged: sage-5.1.beta6

Issue created by migration from https://trac.sagemath.org/ticket/12009

@sagetrac-mariah sagetrac-mariah mannequin added this to the sage-5.1 milestone Nov 10, 2011
@mwhansen
Copy link
Contributor

Author: Mike Hansen

@sagetrac-dsm
Copy link
Mannequin

sagetrac-dsm mannequin commented May 25, 2012

comment:2

Works for me: applies cleanly against 5.1.beta0 and passes the tests afterwards.

@kcrisman
Copy link
Member

comment:3

Mike,

This looks like the right fix, efficient as always, and Doug tested it. Should we at this point make the attribute a single-underscore one instead of double-underscore?

@mwhansen
Copy link
Contributor

Attachment: trac_12009.patch.gz

@mwhansen
Copy link
Contributor

comment:4

I just went ahead and made the double underscore into a single one. Positive review?

@mwhansen
Copy link
Contributor

Changed keywords from none to sd40.5

@kcrisman
Copy link
Member

comment:5

Great!

@kcrisman
Copy link
Member

Reviewer: Douglas S. McNeil, Karl-Dieter Crisman

@jdemeyer
Copy link

Merged: sage-5.1.beta6

@jdemeyer
Copy link

Changed reviewer from Douglas S. McNeil, Karl-Dieter Crisman to Douglas McNeil, Karl-Dieter Crisman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants