Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Safe Singleton Factory for Deployments #473

Closed
nlordell opened this issue Jul 22, 2024 · 1 comment · Fixed by #477
Closed

Use Safe Singleton Factory for Deployments #473

nlordell opened this issue Jul 22, 2024 · 1 comment · Fixed by #477
Assignees
@remedcu

Comments

@nlordell
Copy link
Collaborator

nlordell commented Jul 22, 2024 •
edited
Loading

Context / issue

Currently, all our deployments are done using the CREATE2 deployer at 0x4e59b44847b379578588920ca78fbf26c0b4956c. We should change our modules to use the Safe singleton factory, just like we do for our core contracts.

Affected modules:

  • 4337
  • Passkeys
  • Recovery
  • Allowance

Make sure to update the expected address and include this in the CHANGELOG for the respective projects.
@remedcu remedcu mentioned this issue Aug 15, 2024
Merged
@remedcu
Copy link
Member

remedcu commented Aug 15, 2024

Closed by #477

@remedcu remedcu closed this as completed Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@remedcu remedcu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using safe-singleton-factory for module deployment safe-global/safe-modules
2 participants
@nlordell @remedcu