Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas benchmarking in 4337 tests outputs gas used for the transaction instead of user operation gas #425

Closed
mmv08 opened this issue May 21, 2024 · 0 comments · Fixed by #446
Assignees

Comments

@mmv08
Copy link
Member

mmv08 commented May 21, 2024

Description

Shebin and I were looking at the gas discrepancy between our local bundler tests and the Alchemy bundler:

| **[Without Paymaster](../../modules/4337/test/gas/Gas.spec.ts)** | Yes | 415213 | 447632 | 182081 | 426139 | 160575 | 467926 | 202374 |

We realised that in the 4337 tests, we consider transaction gas instead of the user operation gas [what we use in benchmarks].

We should adjust the 4337 tests to use the same method. Reference code is available here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant