Supporting empty Content-Length headers by ignoring them. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Jan 2, 2017
| if (null === $contentLength) { | ||
| return stream_get_contents($body); | ||
| } else { | ||
| if (is_int($contentLength) || ctype_digit($contentLength)) { |
There was a problem hiding this comment.
Does this lib already depend on the ctype ext?
There was a problem hiding this comment.
Alternativ could be a cast to int
There was a problem hiding this comment.
It does. I didn't realize it was an extension. I'll add it to the require list to make sure this is captured
There was a problem hiding this comment.
The cast to int would turn an empty string into a 0, and instead I want an invalid value to be ignored altogether.
There was a problem hiding this comment.
$i = (int) $contentLength;
If ($i > 0 && $i != $contentLength)
...
But as you already depend on ctypes its fine.
staabm
approved these changes
Jan 2, 2017
Closed
This was referenced May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72