Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Easy Emoji #570

Closed
yunussukrugulten opened this issue Jan 9, 2023 · 4 comments · Fixed by #589
Closed

Update React Easy Emoji #570

yunussukrugulten opened this issue Jan 9, 2023 · 4 comments · Fixed by #589
Labels
enhancement New feature or request

Comments

@yunussukrugulten
Copy link

yunussukrugulten commented Jan 9, 2023

Summary

Hello,

The baseurl(twemoji.maxcdn.com) in the react easy repository has not been working for a while and cdn cloudflare address is used instead of twemoji.maxcdn.com.

I recommend you update.
SaadEmojiError1
SaadEmojiError2

What's new?

You can get the update from the link

https://github.com/appfigures/react-easy-emoji

Changelog

appfigures/react-easy-emoji@e6c3949

Motivation

To see emojis :)

Additional context

If you are using a content security policy, I recommend updating the new address with twemoji.maxcdn.com, otherwise your emojis will not be visible.

@yunussukrugulten yunussukrugulten added the enhancement New feature or request label Jan 9, 2023
@ajaymajmudar
Copy link

Having the same emoji issue. How does one fix this with the update? i tried npm install --save react-easy-emoji and that doesn't work.

@yunussukrugulten
Copy link
Author

yunussukrugulten commented Jan 9, 2023

Having the same emoji issue. How does one fix this with the update? i tried npm install --save react-easy-emoji and that doesn't work.

Hello,

Follow these instructions in the folder where your project is located;

  1. Enter the node_modules folder,
  2. Then go to react-easy-emoji folder,
  3. Replace the updated sections here https://github.com/appfigures/react-easy-emoji,
  4. Clear your browser cache before running npm start and run and then build.

Updated files;

  1. https://github.com/appfigures/react-easy-emoji/blob/master/test/test.js
  2. https://github.com/appfigures/react-easy-emoji/blob/master/lib/makeTwemojiRenderer.js

Regards

@saadpasta
Copy link
Owner

@yunussukrugulten is there any other way of doing it maybe through dependency update or should we wait until they resolve this issue

@yunussukrugulten
Copy link
Author

yunussukrugulten commented Jan 10, 2023

is there any other way of doing it maybe through dependency update or should we wait until they resolve this issue

Hello,

Frankly, I'm following the React Easy Emoji repo for the moment. When I couldn't see the emojis on my own website, I immediately looked on github and saw that the repo was updated.

I don't know if twemoji.maxcdn.com will be reactivated or remain inactive, but I needed to take an action for the emojis to work and I acted according to the repo and made the necessary updates.

Emojis now appear seamlessly on my website.

My website: https://yunussukrugulten.com

I leave the decision to you.

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants