Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on Dropdowns autofocusing when setting starting options #271

Closed
gnbm opened this issue Aug 17, 2023 · 9 comments
Closed

Issue on Dropdowns autofocusing when setting starting options #271

gnbm opened this issue Aug 17, 2023 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@gnbm
Copy link
Collaborator

gnbm commented Aug 17, 2023

  • Issue on Dropdowns autofocusing when setting starting options:

IssueAutoFocusVS

@gnbm
Copy link
Collaborator Author

gnbm commented Aug 17, 2023

@sa-si-dev Created this PR to roll back the unwanted behaviour that was introduced.

Important Note:
The original issue that the PR wanted to address will still occur so it will need to be done differently and here maybe you could quickly fix this differently since you know much better all the component lifecycle and events.

@sa-si-dev
Copy link
Owner

sa-si-dev commented Aug 18, 2023

@gnbm no need to rollback the privious change.
I have checked-in the fix for this issue. But it hasn't released yet.

Fix commit
fd407b8

@gnbm
Copy link
Collaborator Author

gnbm commented Aug 18, 2023

@sa-si-dev Will run some tests and will give you some feedback. Meanwhile, closed the PR. Cheers

@gnbm
Copy link
Collaborator Author

gnbm commented Aug 21, 2023

@sa-si-dev Just a follow-up. Just run a batch of tests with the change you did in the commit and it works perfectly.
Do you have a release planned?
Thank you!

@sa-si-dev
Copy link
Owner

@sa-si-dev Just a follow-up. Just run a batch of tests with the change you did in the commit and it works perfectly.
Do you have a release planned?
Thank you!

Could you please create a new release with this issue fix only.

@gnbm
Copy link
Collaborator Author

gnbm commented Aug 21, 2023

Could you please create a new release with this issue fix only

@sa-si-dev Sure, I'll try to do it this week and ask for your validation since I still can't run the tests or the validate command without getting tons of errors.
Would it be possible to also have your help on fixing these issues: #162 / #169 / #244? They are having some impact and I don't know the library enough yet to be able to quickly fix them. It would be really helpful!

@sa-si-dev sa-si-dev self-assigned this Aug 23, 2023
@sa-si-dev sa-si-dev added the bug Something isn't working label Aug 23, 2023
@sa-si-dev
Copy link
Owner

@gnbm This issue has been fixed in the release v1.0.40

@sa-si-dev
Copy link
Owner

Could you please create a new release with this issue fix only

@sa-si-dev Sure, I'll try to do it this week and ask for your validation since I still can't run the tests or the validate command without getting tons of errors.
Would it be possible to also have your help on fixing these issues: #162 / #169 / #244? They are having some impact and I don't know the library enough yet to be able to quickly fix them. It would be really helpful!

@gnbm I will fix other issues in the future release.

@gnbm
Copy link
Collaborator Author

gnbm commented Aug 23, 2023

Could you please create a new release with this issue fix only

@sa-si-dev Sure, I'll try to do it this week and ask for your validation since I still can't run the tests or the validate command without getting tons of errors.
Would it be possible to also have your help on fixing these issues: #162 / #169 / #244? They are having some impact and I don't know the library enough yet to be able to quickly fix them. It would be really helpful!

@gnbm I will fix other issues in the future release.

@sa-si-dev That would be amazing since the impacts on my case are quite big. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants