Skip to content
This repository has been archived by the owner on Dec 1, 2019. It is now read-only.

[3.0.0-beta.17] Incompatible with webpack.OldWatchingPlugin #331

Closed
mekwall opened this issue Dec 21, 2016 · 3 comments
Closed

[3.0.0-beta.17] Incompatible with webpack.OldWatchingPlugin #331

mekwall opened this issue Dec 21, 2016 · 3 comments

Comments

@mekwall
Copy link

mekwall commented Dec 21, 2016

When using webpack.OldWatchingPlugin at-loader will throw the following error after a save:

xxx\node_modules\awesome-typescript-loader\src\instance.ts:303
        const watcher = watching.compiler.watchFileSystem.watcher || watching.compiler.watchFileSystem.wfs.watcher;

                    ^
TypeError: Cannot read property 'watcher' of undefined
    at Compiler.<anonymous> (xxx\node_modules\awesome-typescript-loader\src\instance.ts:303:107)
    at Compiler.next (xxx\node_modules\webpack\node_modules\tapable\lib\Tapable.js:69:14)
    at Compiler.invalidAsyncPlugin (xxx\node_modules\webpack-dev-middleware\middleware.js:80:3)
    at Compiler.next (xxx\node_modules\webpack\node_modules\tapable\lib\Tapable.js:69:14)
    at Compiler.<anonymous> (xxx\node_modules\awesome-typescript-loader\src\watch-mode.ts:12:13)
    at Compiler.applyPluginsAsync (xxx\node_modules\webpack\node_modules\tapable\lib\Tapable.js:71:13)
    at Watching._go (xxx\node_modules\webpack\lib\Compiler.js:44:16)
    at Watching.invalidate (xxx\node_modules\webpack\lib\Compiler.js:108:8)
    at Watching.<anonymous> (xxx\node_modules\webpack\lib\Compiler.js:93:8)
    at Timeout.onTimeout [as _onTimeout] (xxx\node_modules\webpack\lib\node\OldNodeWatchFileSystem.js:234:3)

Addendum: ts-loader had the same issue and it was fixed. Working on a pull request.

@mekwall mekwall changed the title Incompatible with webpack.OldWatchingPlugin [3.0.0-beta.17] Incompatible with webpack.OldWatchingPlugin Dec 21, 2016
@s-panferov
Copy link
Owner

@mekwall why do you need this?

@mekwall
Copy link
Author

mekwall commented Feb 6, 2017

@s-panferov because some of our devs have to use webpack.OldWatchingPlugin to have webpack trigger properly on changed files

@mekwall
Copy link
Author

mekwall commented Oct 11, 2017

No longer necessary for us so closing this.

@mekwall mekwall closed this as completed Oct 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants