Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of bugs and features #2

Open
5 of 6 tasks
vladdez opened this issue Feb 1, 2024 · 1 comment
Open
5 of 6 tasks

List of bugs and features #2

vladdez opened this issue Feb 1, 2024 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Comments

@vladdez
Copy link
Collaborator

vladdez commented Feb 1, 2024

Bugs:

  1. if you select only a single value for the continuous range, the legend complains and the plot breaks
  2. if you start with rows & cols and remove them (by deselecting categorical values) and then try to add them again, you run into weird bugs where the plot is not properly fixed (it looks like you are doing Figure(), ax = Axis(f) - i.e. not correctly assigning the axis to a layout).
  3. the lines are all connected, somehow the NAN trick does not seem to work anymore
  4. when I uncheck the "all fruits" option, I still see fruit conditions. I see that the color changes, but black is also a color, so it is a bit misleading.

Features:

  1. Remove a formula term, e.g. add a small "checkbox" to disable it (set to Any[] or similar), or alternatively right click and text delete - this effectively sets this term to its "typical_value" as already implemented when you uncheck all elements of a categorical predictor.
  2. select predictor <-> feature mapping. We want to select whether row should be used for predictor X or Y or Z.

UX:

  1. Why are the numbers on the slider from top to bottom and the numbers on the color map from bottom to top? Better would be uniformity
  2. Not cool that dropdown menu hides image
  3. Would be nice to remove borders over legend and two spines (top and right)
  4. Add the word: conditions
  5. The word luminance should be reversed

Documentation:

  1. When is widget_signal and when is value_ranges used?
@vladdez vladdez added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Feb 1, 2024
@behinger
Copy link
Member

behinger commented May 5, 2024

  • long formulas are not shown in new line
  • enabling / disabling levels should not influence color-order, right now it does
  • implement single-channel effects function in Unfold.jl
  • no choice yet when multiple continuous predictors are available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants