Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jetbrains Mono font #420

Closed
rickard-von-essen opened this issue Jan 16, 2020 · 10 comments
Closed

Add Jetbrains Mono font #420

rickard-von-essen opened this issue Jan 16, 2020 · 10 comments

Comments

@rickard-von-essen
Copy link

JetBrains recently released a developer focused font called JetBrains Mono that would be great to get in.

@damnskippy
Copy link

See also: #421

@ryanoasis
Copy link
Owner

Checked license, looks good to include. No RFN restriction so meaning we don't have to rename it.. can simply be Jetbrains Mono Nerd Font or something 😄

@ryanoasis ryanoasis added this to the v2.1.0 milestone Jan 19, 2020
@damnskippy
Copy link

Also: JetBrains/JetBrainsMono#10

@ryanoasis
Copy link
Owner

@damnskippy Thanks for the linking and @rickard-von-essen for the tracking issue.

Closing now because #421 is merged.

@jrop
Copy link

jrop commented Jan 21, 2020

Since I am a new user of this repo, I have a stupid question: about how long does it take once the merge-request has landed for Brew packages and the website to be updated?

@ryanoasis
Copy link
Owner

@jrop No that is a not a stupid question 😄

Merge requests don't really kick off anything in terms of releases or website updates. Master branch is almost a develop branch in that sense.

The brew packages I am aware of target the release archives so we would have to cut a new release. This process is mostly automated with some manual work involved.

Typically the website is updated after the release is pushed out.

Hope that helps.

@danielwaltz
Copy link

Any chance of a new release in the near future? I'm interested in getting the nerd font patched version of this font added to homebrew-cask-fonts.

@ryanoasis
Copy link
Owner

@danielwaltz There's always a chance 😉

But seriously, yes there is a very good chance there will be a release very soon. I don't want to give a date to avoid disappointment.

I am not just being optimistic but I have reasons:

  1. I've just gotten back into serious efforts to make a much overdue release (PRs merged, triaging some overdue issues)
  2. The archiving script wasn't working and was not adding a few fonts
  3. I am trying to mentally shift from making sure everything is perfect but instead just make reasonable tests

@danielwaltz
Copy link

That's good to hear! Take as long as you need. Really appreciate your contributions!

@github-actions
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants