From da374205d6f5175dffe14fa5244f82666a246ee7 Mon Sep 17 00:00:00 2001 From: Dave Brosius Date: Wed, 25 May 2016 20:19:12 -0400 Subject: [PATCH] avoid map lookups, in loops --- .../com/netflix/hystrix/HystrixObservableCollapser.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hystrix-core/src/main/java/com/netflix/hystrix/HystrixObservableCollapser.java b/hystrix-core/src/main/java/com/netflix/hystrix/HystrixObservableCollapser.java index 0ee9f94d9..9f32fc734 100644 --- a/hystrix-core/src/main/java/com/netflix/hystrix/HystrixObservableCollapser.java +++ b/hystrix-core/src/main/java/com/netflix/hystrix/HystrixObservableCollapser.java @@ -202,8 +202,7 @@ public void call(BatchReturnType batchReturnType) { @Override public void call(Throwable t) { Exception ex = getExceptionFromThrowable(t); - for (K key: requestsByKey.keySet()) { - CollapsedRequest collapsedReq = requestsByKey.get(key); + for (CollapsedRequest collapsedReq : requestsByKey.values()) { collapsedReq.setException(ex); } } @@ -212,8 +211,9 @@ public void call(Throwable t) { @Override public void call() { - for (K key : requestsByKey.keySet()) { - CollapsedRequest collapsedReq = requestsByKey.get(key); + for (Map.Entry> entry : requestsByKey.entrySet()) { + K key = entry.getKey(); + CollapsedRequest collapsedReq = entry.getValue(); if (!seenKeys.contains(key)) { try { onMissingResponse(collapsedReq);