Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://captive.apple.com/ is not a reliable connectivity check URL #41

Closed
AleSpero opened this issue Apr 20, 2020 · 3 comments
Closed
Assignees
Labels

Comments

@AleSpero
Copy link

AleSpero commented Apr 20, 2020

Is your feature request related to a problem? Please describe.
Many countries around the world (Brazil, United Arab Emirates, China, and more) are blocking the default https://captive.apple.com/ connectivity URL for some reason, and since the default success threshold is set at 75%, the app would report no internet connection every time in one of those countries.

Describe the solution you'd like
There are a couple of possible solutions:

  1. Lowering the default connectivity threshold to 50%

  2. Adding a different HTTPS URL for checking the internet connection (On this one I think it can be hard to find an URL that's ok for all the countries)

  3. Strictly enforcing setting a custom URL for developers.

Thanks for the attention and for your hard work on this library. :)

@rwbutler rwbutler added the bug label Apr 21, 2020
@rwbutler rwbutler self-assigned this Apr 21, 2020
@rwbutler
Copy link
Owner

Thanks for letting me know about this! I wasn't aware that specific connectivity URL is blocked in certain places. I'd like things to continue to function 'out of the box' so I'll lower the default threshold to 50% since I've already added all the connectivity URLs I'm currently aware of. I've always recommended that users of the library host their own connectivity endpoint and use that instead of the examples provided so I may try to make that more prominent in the documentation.

@AleSpero
Copy link
Author

Ok! Thank you 😄

@rwbutler
Copy link
Owner

No problem! I've just released 3.3.4 which includes the change 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants