Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnixTime doesn't impl Ord #56

Closed
devanlai opened this issue Sep 23, 2024 · 1 comment
Closed

UnixTime doesn't impl Ord #56

devanlai opened this issue Sep 23, 2024 · 1 comment

Comments

@devanlai
Copy link
Contributor

I was trying to compute the max of two UnixTimes when I noticed that UnixTime doesn't actually implement Ord, even though it seems like it should be completely safe to implement it given that it already implements PartialOrd and Eq.
@djc
Copy link
Member

djc commented Sep 23, 2024

Makes sense. Want to send a PR?

@devanlai devanlai mentioned this issue Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@djc @devanlai