Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate into compiler #105

Closed
ishitatsuyuki opened this issue Feb 3, 2017 · 5 comments
Closed

Integrate into compiler #105

ishitatsuyuki opened this issue Feb 3, 2017 · 5 comments

Comments

@ishitatsuyuki
Copy link

The match clause accepts any type of literal, which is syntaxically similar to phf maps. I feel we could simply code it in the compiler to make an intelligent match.
@sfackler
Copy link
Collaborator

sfackler commented Feb 3, 2017

This seems like an issue for rust-lang/rfcs rather than here?

@ishitatsuyuki
Copy link
Author

I'm not sure if it should have a RFC, since it's completely transparent to the user.

@sfackler
Copy link
Collaborator

sfackler commented Feb 4, 2017

rust-lang/rust then maybe - in either case the decision that would be made is related to rustc not phf.

@ishitatsuyuki
Copy link
Author

rust-lang/rust#39525

@sfackler
Copy link
Collaborator

sfackler commented Feb 5, 2017

Great, thanks!

@sfackler sfackler closed this as completed Feb 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sfackler @ishitatsuyuki