Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndarray::iter::Iter doesn't implement Debug #1204

Closed
liam-clink opened this issue Sep 4, 2022 · 4 comments
Closed

ndarray::iter::Iter doesn't implement Debug #1204

liam-clink opened this issue Sep 4, 2022 · 4 comments
Labels
enhancement good first issue A good issue to start contributing to ndarray!

Comments

@liam-clink
Copy link

The title says it. What I was trying to do when I discovered this was print a zip of a range and an ndarray.

Like so:

let foo = ndarray::Array1::<f64>::zeros(100);
println!("{:?}", std::iter::zip(0..foo.len(), &foo);
@nilgoyette
Copy link
Collaborator

I never thought of printing an iterator before! Anyway, as per the official documentation:

fmt::Debug implementations should be implemented for all public types.

So, yeah, I guess we should do it.

@nilgoyette nilgoyette added good first issue A good issue to start contributing to ndarray! enhancement labels May 27, 2023
@biskwikman
Copy link
Contributor

I'm not very experienced with Rust projects, but I'd like to try to implement this. Is Iter found in the iterators/mod.rs file?

@nilgoyette
Copy link
Collaborator

Yes, probably. Just clone the project and test, you will see.

@bluss
Copy link
Member

bluss commented Mar 11, 2024

Fixed in #1353, thanks and thanks @nilgoyette for mentoring

@bluss bluss closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue A good issue to start contributing to ndarray!
Projects
None yet
Development

No branches or pull requests

4 participants