Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

future compat lints #461

Closed
Mark-Simulacrum opened this issue Oct 9, 2019 · 0 comments · Fixed by #494
Closed

future compat lints #461

Mark-Simulacrum opened this issue Oct 9, 2019 · 0 comments · Fixed by #494
Labels
S-blocked Status: this PR is blocked waiting for something

Comments

@Mark-Simulacrum
Copy link
Member

Once rust-lang/rust#65193 (hopefully) lands, future compatibility lints will have a slightly new registration format:

A @future_incompatible "field" is used in the declare_lint macro, e.g.,

declare_lint! {
    pub DUPLICATE_MACRO_EXPORTS,
    Deny,
    "detects duplicate macro exports"
    @future_incompatible = FutureIncompatibleInfo {
        reference: "issue #35896 <https://github.com/rust-lang/rust/issues/35896>",
        edition: Some(Edition::Edition2018),
    },
}

We will also want to include this comment somehow:

    // Guidelines for creating a future incompatibility lint:
    //
    // - Create a lint defaulting to warn as normal, with ideally the same error
    //   message you would normally give
    // - Add a suitable reference, typically an RFC or tracking issue. Go ahead
    //   and include the full URL, sort items in ascending order of issue numbers.
    // - Later, change lint to error
    // - Eventually, remove lint
@Mark-Simulacrum Mark-Simulacrum added the S-blocked Status: this PR is blocked waiting for something label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-blocked Status: this PR is blocked waiting for something
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant