Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide guidance on working with out-of-tree crates #285

Closed
davidtwco opened this issue Mar 2, 2019 · 5 comments
Closed

Provide guidance on working with out-of-tree crates #285

davidtwco opened this issue Mar 2, 2019 · 5 comments

Comments

@davidtwco
Copy link
Member

It would be worthwhile to document all of the best practices surrounding working with out-of-tree crates and the compiler.

This issue exists to be linked to by the crates policy in the compiler-team repository.
Related to #268.

@mark-i-m
Copy link
Member

mark-i-m commented Mar 2, 2019

@davidtwco Would you be interested in starting such a chapter?

@davidtwco
Copy link
Member Author

@mark-i-m I don't have any experience working with out-of-tree crates, so unfortunately I don't know what the best practices to document are. Someone who has worked on chalk or polonius would be in a good position to document these.

@mark-i-m
Copy link
Member

@tmandry @scalexm or @nikomatsakis (worked on chalk), and I know that @RalfJung and @oli-obk work on miri, and @Mark-Simulacrum works on infra. Perhaps one of them has some info or would be willing to type up a short PR (it would be much appreciated <3)?

@jyn514
Copy link
Member

jyn514 commented Mar 26, 2023

@davidtwco do you think the new chapter I added in #1653 (which is really just moving around info in contributing.md today) documents this well enough we could close the issue?

@davidtwco
Copy link
Member Author

@davidtwco do you think the new chapter I added in #1653 (which is really just moving around info in contributing.md today) documents this well enough we could close the issue?

Yeah, I think this looks good.

@jyn514 jyn514 closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants