Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-compiling to s390x musl is missing __rdl_alloc when codegen-units-std is not set to 1 #83600

Closed
jyn514 opened this issue Mar 28, 2021 · 4 comments
Labels
A-cross Area: Cross compilation C-bug Category: This is a bug. O-musl Target: The musl libc O-SystemZ Target: SystemZ processors (s390x) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jyn514
Copy link
Member

jyn514 commented Mar 28, 2021

I do not have the time or hardware to replicate this. The original error came up in zulip: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/bootstrapping.20on.20s390x.2Fmips.20for.20musl/near/227436553

cc @Mark-Simulacrum @kaniini @nagisa

@jyn514 jyn514 added A-cross Area: Cross compilation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. O-SystemZ Target: SystemZ processors (s390x) labels Mar 28, 2021
@kaniini
Copy link
Contributor

kaniini commented Mar 28, 2021

This is because of musl actually. It’s because libc needed to be adapted for musl s390x i believe.

@jyn514
Copy link
Member Author

jyn514 commented Mar 28, 2021

This is because of musl actually. It’s because libc needed to be adapted for musl s390x i believe.

Does that mean you can replicate this on x86_64-musl? What changes does libc need?

@kaniini
Copy link
Contributor

kaniini commented Mar 28, 2021

The libc crate did not have definitions for musl on s390x. I think the latest libc crate will be fine. And yes, it is reproducible when building a cross compiler.

@jyn514 jyn514 changed the title Cross-compiling to s390x is missing __rdl_alloc when codegen-units-std is not set to 1 Cross-compiling to s390x musl is missing __rdl_alloc when codegen-units-std is not set to 1 Mar 28, 2021
@camelid camelid added the O-musl Target: The musl libc label Apr 8, 2021
@jyn514
Copy link
Member Author

jyn514 commented Jun 6, 2021

The libc crate did not have definitions for musl on s390x. I think the latest libc crate will be fine. And yes, it is reproducible when building a cross compiler.

I think this is fixed then? Or at least, this issue isn't tracking anything useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cross Area: Cross compilation C-bug Category: This is a bug. O-musl Target: The musl libc O-SystemZ Target: SystemZ processors (s390x) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants