Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad compiler error messages while using diesel #83383

Open
weiznich opened this issue Mar 22, 2021 · 4 comments
Open

Bad compiler error messages while using diesel #83383

weiznich opened this issue Mar 22, 2021 · 4 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-trait-system Area: Trait system D-confusing Diagnostics: Confusing error or lint that should be reworked. D-newcomer-roadblock Diagnostics: Confusing error or lint; hard to understand for new users. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@weiznich
Copy link
Contributor

Following this request on twitter I've put together a "best of" of some compiler errors that can occur if something went wrong while using diesel. The test cases are mostly taken out of our issue tracker, containing things our users have encountered in the past. So cc @estebank

See this repository for the code examples with some explanation what's going wrong there and what would be more helpful in my opinion. Feel free to contact me for any diesel related question about those error messages.

@weiznich weiznich added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 22, 2021
@jyn514 jyn514 added the A-trait-system Area: Trait system label Mar 22, 2021
@weiznich

This comment has been minimized.

@estebank estebank added D-confusing Diagnostics: Confusing error or lint that should be reworked. D-newcomer-roadblock Diagnostics: Confusing error or lint; hard to understand for new users. labels Apr 1, 2021
@Aaron1011
Copy link
Member

I've opened #83794 to track fixing the underlying cause of bad_insertable.rs.

@weiznich
Copy link
Contributor Author

#51992 Would probably help much with the bad_insertable case. (I believe this error message was the motivate to write the corresponding RFC back then)

@estebank
Copy link
Contributor

CC #28894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-trait-system Area: Trait system D-confusing Diagnostics: Confusing error or lint that should be reworked. D-newcomer-roadblock Diagnostics: Confusing error or lint; hard to understand for new users. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants