Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

warning for missing config.toml doesn't consider $RUST_BOOTSTRAP_CONFIG #77293

Closed
davidtwco opened this issue Sep 28, 2020 · 0 comments · Fixed by #77298
Closed

warning for missing config.toml doesn't consider $RUST_BOOTSTRAP_CONFIG #77293

davidtwco opened this issue Sep 28, 2020 · 0 comments · Fixed by #77298
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@davidtwco
Copy link
Member

If a config.toml is provided via $RUST_BOOTSTRAP_CONFIG, not by having a config.toml in the working directory, then warning: you have not made a 'config.toml' is printed incorrectly.

cc @jyn514
@jonas-schievink jonas-schievink added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-bug Category: This is a bug. labels Sep 28, 2020
@jyn514 jyn514 mentioned this issue Sep 28, 2020
Merged
@bors bors closed this as completed in d92d28e Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't warn if the config file is somewhere other than config.toml jyn514/rust
2 participants
@davidtwco @jonas-schievink