Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing "mono item" terminology #74432

Closed
davidtwco opened this issue Jul 17, 2020 · 1 comment
Closed

Consider changing "mono item" terminology #74432

davidtwco opened this issue Jul 17, 2020 · 1 comment
Labels
-Zpolymorphize Unstable option: Polymorphization. A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@davidtwco
Copy link
Member

Requested by @eddyb in this comment. After polymorphisation (#69749) lands, mono items may not actually be monomorphic and so it might be worth changing the terminology here, e.g. "codegen item".
@davidtwco davidtwco mentioned this issue Jul 17, 2020
Merged
@davidtwco davidtwco added A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 17, 2020
@camelid camelid added the -Zpolymorphize Unstable option: Polymorphization. label Oct 3, 2020
@fmease
Copy link
Member

fmease commented Feb 11, 2025

#133883 removed polymorphization, all of its tests and crash tests.

Given the MCP criticized the way the now removed implementation of polymorphization invalidated a lot of assumptions when optimizing MIR and when monomorphizing, I presume that any future design will work rather differently and thus this issue won't apply directly anymore. Feel free to correct me.

Closing as not planned.

@fmease fmease closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
-Zpolymorphize Unstable option: Polymorphization. A-codegen Area: Code generation C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davidtwco @fmease @camelid