Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm test failures do not contain error messages #62556

Open
tmandry opened this issue Jul 10, 2019 · 1 comment
Open

wasm test failures do not contain error messages #62556

tmandry opened this issue Jul 10, 2019 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. O-wasm Target: WASM (WebAssembly), http://webassembly.org/

Comments

@tmandry
Copy link
Member

tmandry commented Jul 10, 2019

When our tests fail in bors on a wasm target, there is no error message except RuntimeError: unreachable (example). There is nothing to print the panic message to the console.

I think this could be fixed by adding console_error_panic_hook as dependency somehow, but I'm not quite sure how to do this.

Here's an example project that sets up this dependency to run with a test: async-fn-size. Thanks to @Mark-Simulacrum for figuring this out!

@jonas-schievink jonas-schievink added A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. O-wasm Target: WASM (WebAssembly), http://webassembly.org/ labels Jul 10, 2019
@oli-obk
Copy link
Contributor

oli-obk commented Nov 29, 2019

In #66321 (comment) it was suggested to try to

use std::panic::set_hook only during the tests to retrieve the panic message?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. O-wasm Target: WASM (WebAssembly), http://webassembly.org/
Projects
None yet
Development

No branches or pull requests

3 participants