Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.17 regression - named-block 0.3.1 #40959

Closed
alexcrichton opened this issue Mar 31, 2017 · 9 comments
Closed

Rust 1.17 regression - named-block 0.3.1 #40959

alexcrichton opened this issue Mar 31, 2017 · 9 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.

Comments

@alexcrichton
Copy link
Member

   Compiling named-block v0.3.1 (file:///home/alex/code/named-block)
   Compiling static-cond v0.1.1
error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

thread 'rustc' panicked at 'called `Option::unwrap()` on a `None` value', /checkout/src/libcore/option.rs:323
note: Run with `RUST_BACKTRACE=1` for a backtrace.

error: Could not compile `named-block`.

To learn more, run the command again with --verbose.

Only regresses against beta, fixed in nightly. Do we have a PR tagged with a backport to fix this?

@alexcrichton alexcrichton added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Mar 31, 2017
@alexcrichton
Copy link
Member Author

cc @rust-lang/compiler

@alexcrichton
Copy link
Member Author

May also affect rustasm6502

cc @jonas-schievink

@alexcrichton
Copy link
Member Author

Likely also uom

cc @iliekturtles

@durka
Copy link
Contributor

durka commented Mar 31, 2017

cc me :)

@iliekturtles
Copy link
Contributor

iliekturtles commented Mar 31, 2017

Looks like #40813. There are nested macro_rules! in static-cond. Since landing in nightly uom is building again.

@alexcrichton
Copy link
Member Author

@jseyfried can you confirm #40813 fixes this? If so then we can close as that's nominated for a backport

@alexcrichton
Copy link
Member Author

er, didn't mean to close yet

@durka
Copy link
Contributor

durka commented Apr 1, 2017

I can confirm that cherry-picking #40813 on top of the beta branch fixes named-block.

@alexcrichton
Copy link
Member Author

Thanks @durka!

In that case we'll track this with the other backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Projects
None yet
Development

No branches or pull requests

3 participants