Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-pass multidispatch tests trigger UAC on Windows #21352

Closed
klutzy opened this issue Jan 18, 2015 · 3 comments
Closed

run-pass multidispatch tests trigger UAC on Windows #21352

klutzy opened this issue Jan 18, 2015 · 3 comments
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc A-trait-system Area: Trait system O-windows Operating system: Windows

Comments

@klutzy
Copy link
Contributor

klutzy commented Jan 18, 2015

UAC thinks it is something about patch :(
cc #10512 and #11207

@kmcallister kmcallister added O-windows Operating system: Windows A-trait-system Area: Trait system A-testsuite Area: The testsuite used to check the correctness of rustc labels Jan 18, 2015
@bombless
Copy link
Contributor

Actually, rustc -o _dipatch or rustc -o dispatch_ will trigger UAC while rustc -o dispatch won't.

@ColonelJ
Copy link
Contributor

I'm planning to figure out a way to fix #11207 and add proper support for manifests to Rust (I think all Windows binaries ought to have one, to enable visual styles, show application version number etc.), but as noted here as a temporary measure for this particular problem all you need to do is set an environment variable __COMPAT_LAYER as RunAsInvoker on your machine and you'll be able to run those tests fine.

I've made a pull request #21496 for this which make the test runner set this variable so you don't have to set it globally and affect the normal running of your box w.r.t. setup.exe and friends. Though I expect most Rust developers on Windows would be smart enough to figure out that a right click -> Run As Administrator might be required when it brings up some privilege related error! Even so, it's better if it just compiles and passes test 'out of the box' so to speak, after you've already gone through all the faff of installing some Rust-compatible MINGW (and Python, and whatever else...) on your machine.

@klutzy
Copy link
Contributor Author

klutzy commented Mar 17, 2015

Fixed by #21496. (Executables still don't have manifest, but it's other issue: #10512/#11207)

@klutzy klutzy closed this as completed Mar 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc A-trait-system Area: Trait system O-windows Operating system: Windows
Projects
None yet
Development

No branches or pull requests

4 participants