Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SocketAddr to InetAddr #16595

Closed
carllerche opened this issue Aug 19, 2014 · 10 comments
Closed

Rename SocketAddr to InetAddr #16595

carllerche opened this issue Aug 19, 2014 · 10 comments
Assignees
@alexcrichton
Milestone
1.0 beta

Comments

@carllerche
Copy link
Member

SocketAddr should be an enum of all possible addresses that can be used for sockets, including unix domain sockets and any other socket flavors. What is currently named SocketAddr is really an InetAddr.
@frewsxcv
Copy link
Member

Triage: This sounds very reasonable. I haven't been following the IO reform stuff too closely, but as far as I know, the io::net submodule has yet to be proposed

@steveklabnik
Copy link
Member

/cc @aturon

@frewsxcv
Copy link
Member

Relevant RFC PR: rust-lang/rfcs#807

@frewsxcv frewsxcv mentioned this issue Feb 15, 2015
Merged
@aturon
Copy link
Member

aturon commented Feb 16, 2015

Hm, unfortunately this wasn't taken into account with IO reform, and seems to still be an issue. The renaming makes sense to me. Thoughts, @alexcrichton?

@aturon
Copy link
Member

aturon commented Feb 16, 2015

Nominating for 1.0-beta P-backcompat-libs.

@alexcrichton
Copy link
Member

We may wish to reconsider the socket_addr method names on each of the socket types as well, but this renaming is fine by me.

@pnkfelix
Copy link
Member

P-backcompat-libs, 1.0 beta

@pnkfelix pnkfelix added this to the 1.0 beta milestone Feb 19, 2015
@carllerche
Copy link
Member Author

I submitted an RFC PR for this change: rust-lang/rfcs#923

@nikomatsakis
Copy link
Contributor

I'm assigning this to @alexcrichton (trying to reduce the number of milestone issues with no assignee).

@alexcrichton
Copy link
Member

Decided in rust-lang/rfcs#923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
1.0 beta
Development

No branches or pull requests
7 participants
@carllerche @steveklabnik @alexcrichton @nikomatsakis @pnkfelix @frewsxcv @aturon