-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue for release notes of #83164: Tracking Issue for const_replace #131092
Comments
Ping @workingjubilee since you did the stabilization PR #130954 Not sure how release notes work, should this be its own thing or part of some bigger constification thing like your PR? |
relnotes tag goes on the PR. That PR hasn't landed yet, so this shouldn't be in relnotes. |
...oh this happens automatically on a |
geez, there's going to be like 10 of these... |
I think it happens on FCPs. But I am not sure what event exactly the bot is looking for. |
It looks for labels of any of if let IssuesAction::Labeled { label } = &e.action {
if ["relnotes", "relnotes-perf", "finished-final-comment-period"]
.contains(&label.name.as_str())
{ |
I... guess I'll do this then? |
@rust-lang/release this was part of Rust 1.83. It doesn't have a milestone set because it got created from an FCP on an issue, not from a PR. So I guess it should be closed now? It would be great if someone could document how all the new fancy release notes automation is supposed to work. Many project members can see it in action, but I assume most of us have no clue what the intended workflows here are, who is in charge of doing what, when issues like this one are to be associated with a concrete release, who closes these issues when, ... |
Closing seems reasonable. Docs also seem like a good idea, I can try to spend some time getting a write up in Forge and adding a link to it from the filed issue descriptions. |
That would be great :) |
This issue tracks the release notes text for #83164.
Steps
Release notes text
The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).
Tip
Use the previous releases categories to help choose which one(s) to use.
The category will be de-duplicated with all the other ones by the release team.
More than one section can be included if needed.
Release blog section
If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
Otherwise leave it empty.
cc @usbalbin -- origin issue/PR authors and assignees for starting to draft text
The text was updated successfully, but these errors were encountered: