Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect revision syntax is silently accepted #130815

Open
lcnr opened this issue Sep 25, 2024 · 1 comment
Open

incorrect revision syntax is silently accepted #130815

lcnr opened this issue Sep 25, 2024 · 1 comment
Labels
A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@lcnr
Copy link
Contributor

lcnr commented Sep 25, 2024

rust/tests/ui/traits/coherence-alias-hang.rs

Lines 1 to 5 in 1b5aa96

//@ check-pass
//@ revisions: current next
//[next]@ compile-flags: -Znext-solver
// Regression test for nalgebra hang <https://github.com/rust-lang/rust/issues/130056>.

This test never actually tests the new solver. It has to be //@[next] compile-flags: -Znext-solver. We should lint here ✨
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Sep 25, 2024
@jieyouxu jieyouxu added the A-compiletest Area: The compiletest test runner label Sep 25, 2024
@jieyouxu jieyouxu added C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 25, 2024
@jieyouxu
Copy link
Member

Ah right. This is a bit like #125813 (that issue is // @<directive> does nothing because it's not a valid compiletest directive syntax).

@jieyouxu jieyouxu added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-compiletest Area: The compiletest test runner C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
compiletest maintenance and improvements
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lcnr @jieyouxu @rustbot