Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buggy debuginfo test suite, or just function-names.rs? #126060

Open
workingjubilee opened this issue Jun 6, 2024 · 4 comments
Open

Buggy debuginfo test suite, or just function-names.rs? #126060

workingjubilee opened this issue Jun 6, 2024 · 4 comments
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-bug Category: This is a bug. O-windows Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@workingjubilee
Copy link
Member

In #125958 (a PR which changes the way consts are handled in the compiler, and thus alters details like their hashing, etc.) a few lines were trimmed out of a debuginfo test because it was unreasonable to get it to work, despite the function names seemingly being present.

It seems like there might be a bug in the way that the debuginfo test suite handles [...]? Or it might incorrectly treat certain checks as ordering-sensitive, when hashing can change orders? It's unclear, but in any case, undesirable.

This mostly affected the Windows variant of the test.

@workingjubilee workingjubilee added O-windows Operating system: Windows A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-bug Category: This is a bug. labels Jun 6, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Jun 6, 2024
@workingjubilee
Copy link
Member Author

cc @michaelwoerister

@michaelwoerister michaelwoerister self-assigned this Jun 6, 2024
@michaelwoerister
Copy link
Member

Thanks for the pointer, @workingjubilee! I'll take a look.

@saethlin saethlin added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Jun 7, 2024
@workingjubilee
Copy link
Member Author

workingjubilee commented Jun 10, 2024

To concretize this issue slightly further, I'd like to apply changes as close as possible to the other ones in this patch to the debuginfo test suite: #125963

@BoxyUwU
Copy link
Member

BoxyUwU commented Jul 2, 2024

cc #115786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-debuginfo Area: Debugging information in compiled programs (DWARF, PDB, etc.) C-bug Category: This is a bug. O-windows Operating system: Windows T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants