Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: no variant found in current scope #117053

Closed
Mark-Simulacrum opened this issue Oct 22, 2023 · 3 comments
Closed

regression: no variant found in current scope #117053

Mark-Simulacrum opened this issue Oct 22, 2023 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

https://crater-reports.s3.amazonaws.com/beta-1.74-4/beta-2023-10-21/reg/race-client-0.2.2/log.txt

[INFO] [stdout] error[E0599]: no variant or associated item named `new_for_answer` found for enum `race_core::types::SecretShare` in the current scope
[INFO] [stdout]    --> src/lib.rs:160:42
[INFO] [stdout]     |
[INFO] [stdout] 160 |                 shares.push(SecretShare::new_for_answer(
[INFO] [stdout]     |                                          ^^^^^^^^^^^^^^ variant or associated item not found in `SecretShare`
@Mark-Simulacrum Mark-Simulacrum added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example labels Oct 22, 2023
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 22, 2023
@Mark-Simulacrum Mark-Simulacrum added this to the 1.74.0 milestone Oct 22, 2023
@Noratrieb
Copy link
Member

searched nightlies: from nightly-2023-08-01 to nightly-2023-10-20
regressed nightly: nightly-2023-09-14
searched commit range: d9c8274...8142a31
regressed commit: 735bb7e

bisected with cargo-bisect-rustc v0.6.6

Host triple: x86_64-unknown-linux-gnu
Reproduce with:

cargo bisect-rustc 2023-08-01 --end 2023-10-20 --access github --regress error 

@bvanjoi @petrochenkov

@bvanjoi
Copy link
Contributor

bvanjoi commented Oct 22, 2023

reduced:

mod api {
    pub mod types {
        pub mod common {
            pub enum S {}
            impl S {
                pub fn a() {}
            }
        }

        pub use common::S;
    }
}

mod c {
    pub mod types {
        mod common {
            pub use crate::api::types::*;
            #[derive(Debug)]
            pub enum S {}
            impl S {
                pub fn b() {}
            }
        }

        pub use common::*;
    }
}

use c::types::S;

fn main() {
    S::a();
}

This fix appears to be as expected. it's strange that the regression test doesn't reflect this.

@Mark-Simulacrum Mark-Simulacrum removed E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example labels Oct 22, 2023
@bvanjoi
Copy link
Contributor

bvanjoi commented Oct 22, 2023

This issue can be resolved once RACE-Game/race#11 gets merged.

@apiraino apiraino removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants