From 765cce11b10eabe667b42df1a9a878fe38b713ce Mon Sep 17 00:00:00 2001 From: Max Baumann Date: Mon, 21 Mar 2022 00:04:37 +0100 Subject: [PATCH] refactor: remove need for MethodCall matching --- clippy_lints/src/methods/or_then_unwrap.rs | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/clippy_lints/src/methods/or_then_unwrap.rs b/clippy_lints/src/methods/or_then_unwrap.rs index 28b1bfe8fb5a..be5768c35450 100644 --- a/clippy_lints/src/methods/or_then_unwrap.rs +++ b/clippy_lints/src/methods/or_then_unwrap.rs @@ -39,13 +39,6 @@ pub(super) fn check<'tcx>( return; } - let unwrap_span = if let ExprKind::MethodCall(_, _, span) = unwrap_expr.kind { - span - } else { - // unreachable. but fallback to ident's span ("()" are missing) - unwrap_expr.span - }; - let mut applicability = Applicability::MachineApplicable; let suggestion = format!( "unwrap_or({})", @@ -55,7 +48,7 @@ pub(super) fn check<'tcx>( span_lint_and_sugg( cx, OR_THEN_UNWRAP, - or_span.to(unwrap_span), + unwrap_expr.span.with_lo(or_span.lo()), title, "try this", suggestion,