Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing std::sync::Arc usages with an Arc implementation that has no weak support #14717

Closed
Veykril opened this issue May 2, 2023 · 1 comment · Fixed by #14718
Assignees
Labels
A-perf performance issues C-enhancement Category: enhancement

Comments

@Veykril
Copy link
Member

Veykril commented May 2, 2023

We use Arcs a lot, but never make use of the weak count so it might be beneficial to use a slimmer Arc (for our attribute handling it might even be more beneficial to employ a ThinArc).

@Veykril Veykril added A-perf performance issues C-enhancement Category: enhancement labels May 2, 2023
@lnicola lnicola self-assigned this May 2, 2023
@lnicola
Copy link
Member

lnicola commented May 2, 2023

A prototype of this (which doesn't include the Chalk database part because it's external) seems to save a whooping 2 MB 4 MB of RAM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-perf performance issues C-enhancement Category: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants