Inlay hints should work in attributed items with bodies

[Veykril]

Currently attributes turn these items into macro expansion so our inlay hints disappear from function bodies and the like.

[jonas-schievink]

Inlay hints should work inside all macro invocations if they are unambiguous, I'd say

[Veykril]

I wouldn't say so, there are plenty of macros where showing inlay hints would feel out of place since a lot of them are used for domain specific language purposes. Having inlay hints show up in those might disrupt that.

Attributes on the other hand always take in full items which are valid rust syntax so showing them there at all times shouldn't have problems.

[jhgg]

Hmm, still broken in this situation, using actix-web = "4.0.0-beta.8"

use std::io;

use actix_web::{web, App, HttpServer};

#[actix_web::main]
async fn main() -> io::Result<()> {
    HttpServer::new(move || {
        App::new()
            .route("/foo", web::get().to(handle_health))
            .default_service(web::to(handle_default))
    })
    .bind("0.0.0.0:9090")?
    .run()
    .await
}

async fn handle_health() -> &'static str {
    "ok"
}

async fn handle_default() -> &'static str {
    "ok"
}

[Veykril]

Looks like we expand #[actix_web::main] which produces

#[actix_web::rt::main(system = "::actix_web::rt::System")]
async fn main() -> io::Result<()>{
  HttpServer::new(move| |{
    App::new().route("/foo",web::get().to(handle_health)).default_service(web::to(handle_default))
  }).bind("0.0.0.0:9090")? .run().await
}

but then we fail to expand the actix_web::rt::main.

[Veykril]

Interesting, with the expanded code there pasted into a file it worksthe attribute still doesnt expand, it just typechecks now I suppose

[Veykril]

Ah, actix_web::rt::main is gated behind a cfg(not(test)) so we don't resolve that currently.
Hmm even when it expands the inlays dont work

[Veykril]

I guess this will require #9403, not sure whats wrong but I assume the node down mapping for attributes doesn't work as well as I'd hoped

[Veykril]

So this actually does work, at least on current rustc stable 1.56. It didn't before because we didn't patch the necessary changes for the older proc-macro abi server. #10633 should make it work on the rest.