Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

tracking issue: easy install and go #89

Closed
nrc opened this issue Nov 7, 2016 · 6 comments
Closed

tracking issue: easy install and go #89

nrc opened this issue Nov 7, 2016 · 6 comments
Assignees
Milestone

Comments

@nrc
Copy link
Member

nrc commented Nov 7, 2016

I believe that for an alpha release the RLS must be easy to install. The current process is too high a bar for entry. There are two scenarios:

  • Bare RLS - cargo install should just work and give a running RLS
  • RLS inside VSCode - we should have a VSCode plugin that installs everything it needs - not sure if that means distributing RLS binaries or building the RLS from source.

Also cc #88 which needs to work out the box for a really good user experience.

@nrc nrc added this to the Alpha release milestone Nov 7, 2016
@nrc nrc changed the title Ease of use tracking issue Easy install and go tracking issue Nov 7, 2016
@nrc
Copy link
Member Author

nrc commented Nov 7, 2016

SYS_ROOT env var is part of the friction: #80

@nrc nrc changed the title Easy install and go tracking issue tracking issue: easy install and go Nov 8, 2016
@nrc
Copy link
Member Author

nrc commented Nov 8, 2016

Discussed:

  • for alpha - cargo install should work (put RLS on crates.io, test)
  • later, Rustup integration for downloading bins (no wait to build from source)
  • VSCode plugin should shell out to either Cargo or Rustup to make this transparent to the user

@sophiajt sophiajt removed this from the Alpha release milestone Nov 29, 2016
@nrc
Copy link
Member Author

nrc commented Nov 29, 2016

Turns out that because we link the compiler, using cargo install with Rustup does not work for the RLS (rust-lang/rustup#765). So we need an alternative plan for the alpha release. We are likely to need two workflows one for devs and one for users. The latter will involve either rustup and/or binary distribution and should probably wait for alpha2.

@sophiajt
Copy link

Just to update. cargo install likely won't work as more people move to using rustup. Instead, we'll need to work on a rustup compatible solution. For the time being we'll use an environment variable to find the RLS: #112

@nrc nrc added this to the Beta milestone Dec 29, 2016
@nrc nrc self-assigned this Mar 2, 2017
@nrc
Copy link
Member Author

nrc commented Mar 2, 2017

Current plan is still to use rustup as primary installation mechanism. (cc @brson).

The VSCode plugin should be able to call rustup to install the RLS, the data it needs, and possibly even a compatible toolchain. If Rustup is not installed, the plugin should install it (with user consent).

@sophiajt
Copy link

Now installable through rustup.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants