Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

feature request: warn if src/test/ is modified without modifying compiler/ or src/librustdoc/ #286

Closed
jyn514 opened this issue Sep 3, 2020 · 5 comments

Comments

@jyn514
Copy link
Member

jyn514 commented Sep 3, 2020

This would help prevent an ever-growing backlog for rust-lang/rust#76268.

@jyn514 jyn514 changed the title Warn if src/test/ is modified without modifying compiler/ or src/librustdoc/ feature request: warn if src/test/ is modified without modifying compiler/ or src/librustdoc/ Sep 3, 2020
@matklad
Copy link
Member

matklad commented Sep 3, 2020

I think are more precise rule would work like this:

  • Warn if a PR modifies only library/ and src/test.

This actually should bring false-positive rate to almost zero I think.

@workingjubilee
Copy link
Member

Would this be part of x.py test tidy, or something else?

@jyn514
Copy link
Member Author

jyn514 commented Sep 15, 2020

I don't think it should be part of tidy, because it could have false positives. tidy is a hard error, I want this to be more like submodules where it says 'only do this if you're sure'.

@Mark-Simulacrum
Copy link
Member

It would probably be better as a request against triagebot, where most new functionality should go. We are already receiving the webhook needed for this so mostly a matter of hooking up a check for the rule @matklad laid out above. AFAIK, no checks on the diff of PRs exists in triagebot today so we'll probably need to add some logic for that.

@jyn514
Copy link
Member Author

jyn514 commented Sep 15, 2020

Opened rust-lang/triagebot#831

@jyn514 jyn514 closed this as completed Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants