This repository has been archived by the owner on Mar 14, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 128
feature request: warn if src/test/ is modified without modifying compiler/ or src/librustdoc/ #286
Comments
jyn514
changed the title
Warn if src/test/ is modified without modifying compiler/ or src/librustdoc/
feature request: warn if src/test/ is modified without modifying compiler/ or src/librustdoc/
Sep 3, 2020
I think are more precise rule would work like this:
This actually should bring false-positive rate to almost zero I think. |
Would this be part of |
I don't think it should be part of tidy, because it could have false positives. |
It would probably be better as a request against triagebot, where most new functionality should go. We are already receiving the webhook needed for this so mostly a matter of hooking up a check for the rule @matklad laid out above. AFAIK, no checks on the diff of PRs exists in triagebot today so we'll probably need to add some logic for that. |
Opened rust-lang/triagebot#831 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This would help prevent an ever-growing backlog for rust-lang/rust#76268.
The text was updated successfully, but these errors were encountered: