Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad source view for some crates #535

Closed
RalfJung opened this issue Dec 26, 2019 · 5 comments
Closed

Bad source view for some crates #535

RalfJung opened this issue Dec 26, 2019 · 5 comments

Comments

@RalfJung
Copy link
Member

https://docs.rs/optional/0.5.0/optional/struct.Optioned.html links to https://docs.rs/optional/0.5.0/src/optional/lib.rs.html#1358-1361 which looks like a broken page: the line numbers come first, and then way below the actual code is shown.

@jyn514
Copy link
Member

jyn514 commented Dec 26, 2019

Hmm, that looks like a CSS issue, but it's a page generated by rustdoc ... Do you have the same problem when running cargo doc on optional locally?

@RalfJung
Copy link
Member Author

I think rustdoc used to have a bug that looked exactly like this. Is it possible that docs.rs generated this page with an old rustdoc and still ships it like that?

@RalfJung
Copy link
Member Author

Here's the rustdoc bug: rust-lang/rust#56720

@jyn514
Copy link
Member

jyn514 commented Dec 26, 2019

Yes, that's the issue exactly, the last build was in November 2018: https://docs.rs/crate/optional/0.5.0/builds.

Closing as duplicate of #464.

@jyn514 jyn514 closed this as completed Dec 26, 2019
@jyn514
Copy link
Member

jyn514 commented Dec 27, 2019

@RalfJung I rebuilt optional, so it should work for this specific crate. Other crates built around the same time will still have the same bug, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants