-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings not working #213
Comments
Same here. It has been broken for a while, and it's really annoying. To reproduce:
While rustdoc itself works fine (or may be it has been fixed): https://doc.rust-lang.org/nightly/std/iter/trait.Iterator.html |
No idea? |
Maybe @GuillaumeGomez can help us with this. |
I'll take a look. |
Any update on this? I ran into this today. |
Workaround:
|
I didn't look yet. But I assume it comes from crates that have been generated with a previous rustdoc version.
That's a pretty bad joke (if it's a joke). |
It looks like (at least for some instances of this) the settings page JS file is missing, e.g. https://docs.rs/futures/0.1.26/settings.html tries to load https://docs.rs/futures/0.1.26/settings-20190318-1.35.0-nightly-0f88167f8.js which just returns a redirect to the futures homepage. Trying an absolute URL like the rest of the loaded resources (in this case https://docs.rs/settings-20190318-1.35.0-nightly-0f88167f8.js) returns a 404 instead. |
@Nemo157 Great catch! It looks like we're not hosting that file. I ran a test on a dev server, and it looks like if we start loading that file in, the settings menu starts working. I've posted #332 to start adding that file in with new releases. I'll see what it will take to start hosting prior versions of that file, too. |
Recently Rustdoc has started generating a Settings page, which works fine on the std website, but on docs.rs, never saves the settings.
The browser console gives this error:
Uncaught SyntaxError: Unexpected token <
But doesn't give any more information to track it down any further.
The text was updated successfully, but these errors were encountered: