Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some build-fails are wrongly treated as test-fails. #132

Closed
kennytm opened this issue Sep 13, 2017 · 2 comments
Closed

Some build-fails are wrongly treated as test-fails. #132

kennytm opened this issue Sep 13, 2017 · 2 comments

Comments

@kennytm
Copy link
Member

kennytm commented Sep 13, 2017

From the most recent cargobomb report at rust-lang/rust#44287, the following should be considered build-fail, but are shown as test-fail:

@est31
Copy link
Member

est31 commented Sep 15, 2017

@kennytm i guess that's because "build-fail" means cargo build failed, and "test-fail" means cargo test failed. Examples/doctests/integration tests and most other tests are #[cfg(test)] so not compiled when doing cargo build. Why should these cases be treated differently from how cargo treats them?

@kennytm
Copy link
Member Author

kennytm commented Sep 15, 2017

@est31 I'd expect "build fail" means error in compilation, while "test fail" means error in runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants