Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A --temps-dir option for specifying where the intermediate files are written #423

Closed
1 of 3 tasks
torhovland opened this issue Apr 6, 2021 · 3 comments
Closed
1 of 3 tasks
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team

Comments

@torhovland
Copy link

Proposal

Currently, the compiler puts intermediate files in the output directory, temporarily or permanently, depending on the -C save-temps option. This is a problem if more than one invocation is run in parallel, e.g. for producing different crate types, because the invocations will overwrite each other's intermediate files. This issue is described in rust-lang/rust#10971.

A --temps-dir option for specifying where the intermediate files are written is implemented in rust-lang/rust#83846.

If additional files are specifically requested using --emit asm,llvm-bc,llvm-ir,obj,metadata,link,dep-info,mir, these are considered output files, and will be put in the output directory rather than in the intermediate directory.

This is a backward-compatible change, i.e. if --temps-dir is not specified, the behavior is the same as before.

The name of the option has been chosen to be consistent with -C save-temps as well as with --out-dir.

Precedent

D provides an -od option which does the same as --temps-dir:

ldc2 -relocation-model=pic --shared lib.d -od=shared_lib_objects & ldc2 --lib lib.d -od=static_lib_objects

gcc provides the option to specify a path where each intermediate file goes:

gcc -fPIC -c lib.c -o lib_shared/lib.o & gcc -c lib.c -o lib_static/lib.o

Alternatives

Issue rust-lang/rust#10971 could also have been solved by hashing the command line arguments and adding the hash to the name of the intermediate files.

Mentors or Reviewers

If you have a reviewer or mentor in mind for this work, mention then
here. You can put your own name here if you are planning to mentor the
work.

Process

The main points of the Major Change Process are as follows:

  • File an issue describing the proposal.
  • A compiler team member or contributor who is knowledgeable in the area can second by writing @rustbot second.
    • Finding a "second" suffices for internal changes. If however, you are proposing a new public-facing feature, such as a -C flag, then full team check-off is required.
    • Compiler team members can initiate a check-off via @rfcbot fcp merge on either the MCP or the PR.
  • Once an MCP is seconded, the Final Comment Period begins. If no objections are raised after 10 days, the MCP is considered approved.

You can read more about Major Change Proposals on forge.

Comments

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

@torhovland torhovland added T-compiler Add this label so rfcbot knows to poll the compiler team major-change A proposal to make a major change to rustc labels Apr 6, 2021
@rustbot
Copy link
Collaborator

rustbot commented Apr 6, 2021

This issue is not meant to be used for technical discussion. There is a Zulip stream for that. Use this issue to leave procedural comments, such as volunteering to review, indicating that you second the proposal (or third, etc), or raising a concern that you would like to be addressed.

cc @rust-lang/compiler @rust-lang/compiler-contributors

@rustbot rustbot added the to-announce Announce this issue on triage meeting label Apr 6, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label Apr 8, 2021
@pnkfelix
Copy link
Member

pnkfelix commented May 6, 2021

@rustbot second

@rustbot rustbot added the final-comment-period The FCP has started, most (if not all) team members are in agreement label May 6, 2021
@apiraino
Copy link
Contributor

@rustbot label -final-comment-period +major-change-accepted

@rustbot rustbot added major-change-accepted A major change proposal that was accepted to-announce Announce this issue on triage meeting and removed final-comment-period The FCP has started, most (if not all) team members are in agreement labels May 20, 2021
@apiraino apiraino removed the to-announce Announce this issue on triage meeting label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major-change A proposal to make a major change to rustc major-change-accepted A major change proposal that was accepted T-compiler Add this label so rfcbot knows to poll the compiler team
Projects
None yet
Development

No branches or pull requests

4 participants