Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need a x32 stack probing function #282

Closed
crlf0710 opened this issue Apr 11, 2019 · 6 comments
Closed

Need a x32 stack probing function #282

crlf0710 opened this issue Apr 11, 2019 · 6 comments

Comments

@crlf0710
Copy link
Member

According to rust-lang/rust#59674, such a function is needed to re-enable stack probing on gnux32 in src/probestack.rs.
@crlf0710 crlf0710 mentioned this issue Apr 12, 2019
Closed
@nikic
Copy link
Contributor

nikic commented Jul 24, 2019

x32 stack probing is now reenabled using the probing function for x86_64. I don't think a separate one is needed.

@crlf0710
Copy link
Member Author

Yeah, just need to wait for rust-lang/rust#62808 to land, then we can close this.

@nikic
Copy link
Contributor

nikic commented Jul 24, 2019

Oh sorry, I thought that had already landed after seeing the "merged" message ... but apparently that didn't actually happen.

@bjorn3
Copy link
Member

bjorn3 commented Jul 24, 2019

Actually it is merged into master:

afbeelding

@nikic
Copy link
Contributor

nikic commented Jul 25, 2019

I've manually closed that PR now and it properly went into "merged" state. Github just went a bit crazy...

@crlf0710
Copy link
Member Author

ok, then let's close this too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikic @crlf0710 @bjorn3