-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sanitize environment variables for build scripts #5282
Labels
Comments
Discussed during a meeting: this might be a nice idea in theory, but it really needs some significant design work, to make sure this feature is actually usable. |
The "non-obvious" part doesn't have to be solved by blocking env vars, but can be solved by tracking which ones were used. This is already almost a solved problem, but it's blocked on a showstopping bug: #4587 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Build scripts have access to the parent environment, and this may cause problem because it's not obvious which env vars are actually used by the build script, which hurts reproducible builds.
Perhaps we should use some kind of a whitelist of envvars to pass to build scripts?
The text was updated successfully, but these errors were encountered: