Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn on cargo publish if crate has github repo with out-of-date Cargo.toml #2322

Closed
pnkfelix opened this issue Jan 27, 2016 · 2 comments
Closed

Comments

@pnkfelix
Copy link
Member

This may be a pie-in-the-sky idea, but... I have noticed (both on my own crates and those of other people) that sometimes one does a crate publish but forgets to do a corresponding git push of the source code back over to github.

This can be annoying for very small crates that don't have documentation (where i often resort to browsing the source code on github), since the github provided source is not in sync with the most up-to-date version on crates.io.

It might be nice if cargo were to warn in response to this.

(One might argue that there are issues, like "how would cargo know which branch to look at for the Cargo.toml", but we already have rev tag and branch options that it could look at.)

I would only want this to be a soft-warning, since there are plenty of use cases where one might want to publish to crates.io without updating github.com immediately (or at all).

@alexcrichton
Copy link
Member

In general yeah there's quite a bit of git-management that could happen with integration with cargo publish. There's also tag mangement and warning about untracked files.

This seems reasonable to me in terms of "nice git integration" to have.

@alexcrichton
Copy link
Member

I think that this is now effectivley fixed with tracking untracked files in a git repo, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants