Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for noncedata in secp.sign_ecdsa and secp.sign_ecdsa_recoverable #424

Closed
junderw opened this issue Mar 19, 2022 · 1 comment · Fixed by #425
Closed

Add support for noncedata in secp.sign_ecdsa and secp.sign_ecdsa_recoverable #424

junderw opened this issue Mar 19, 2022 · 1 comment · Fixed by #425

Comments

@junderw
Copy link
Contributor

junderw commented Mar 19, 2022

I would like to add (and am willing to make a PR) these two new methods.

I propose the names be sign_ecdsa_with_noncedata and sign_ecdsa_recoverable_with_noncedata and their function signatures add an extra argument at the end of type [u8; 32] and called noncedata.

Questions:

  1. I would be willing to do this PR, but I want to get an idea of the willingness to add this to the API. Any objections?
  2. Should I also add a new wrapper struct (similar to the other structs such as Message etc.)?
@apoelstra
Copy link
Member

apoelstra commented Mar 21, 2022

  1. Sure, we'll take the new methods.
  2. No, no reason to wrap the data. It's raw, unstructured data and has no security consequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants