Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression on wasm #278

Closed
real-or-random opened this issue Feb 2, 2021 · 2 comments
Closed

Performance regression on wasm #278

real-or-random opened this issue Feb 2, 2021 · 2 comments

Comments

@real-or-random
Copy link
Collaborator

real-or-random commented Feb 2, 2021 •
edited
Loading

@gregdhill wrote this upstream (bitcoin-core/secp256k1#892)

Not sure if this is an issue with the rust-bindings, but the performance of bitcoin-core/secp256k1 is distinctly slower than other Rust based libraries when compiled to Wasm. See the example benchmarks here.

Since this is a regression, it should be easy to git bisect this.

Possibly related: https://twitter.com/alexeiZamyatin/status/1355605818218053637
@elichai
Copy link
Member

elichai commented Feb 2, 2021

Answered in the original issue: bitcoin-core/secp256k1#892 (comment)

@real-or-random
Copy link
Collaborator Author

Solved in bitcoin-core/secp256k1#892 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@real-or-random @elichai