Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokio to 1.0 #1845

Closed
incker opened this issue Oct 17, 2020 · 3 comments
Closed

Update tokio to 1.0 #1845

incker opened this issue Oct 17, 2020 · 3 comments

Comments

@incker
Copy link

incker commented Oct 17, 2020

New version of tokio is released

Better upgrade, to avoid downloading two versions of tokio in projects

@rdettai
Copy link

rdettai commented Nov 23, 2020

If anybody is wondering how to make tokio 0.2 work with 0.3, it is explained here: https://tokio.rs/blog/2020-10-tokio-0-3

This has a performance impact as a thread has to be started runing 0.2, so the update of Rusoto to depend on 0.3 would really be welcomed! 😄

Note: The IoCompat trait [1] did not work for me, I had to find a workaround with the .compat() method.

[1] https://docs.rs/tokio-compat-02/0.1.2/tokio_compat_02/struct.IoCompat.html

@lukesteensen
Copy link

Looks like this should be closed by #1880 /cc @benesch

@benesch
Copy link
Contributor

benesch commented Jan 8, 2021

Indeed! Thanks.

@benesch benesch closed this as completed Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants