Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send compressed payload by gzip #1461

Closed
plazma-prizma opened this issue Jul 4, 2019 · 2 comments
Closed

Send compressed payload by gzip #1461

plazma-prizma opened this issue Jul 4, 2019 · 2 comments

Comments

@plazma-prizma
Copy link
Contributor

plazma-prizma commented Jul 4, 2019

As shown in the API docs, it is possible to send compressed payload on PutMetricData operation.

In order to do that I need to compress payload before it is being signed and need to add Content-Encoding: gzip.

I can only provide my request_dispatcher to client, and on dispatch phase it receives an already SignedRequest which doesn't help.

Can we add an option to compress payload with gzip without sending it?

I would be happy to implement that.

@matthewkmayer
Copy link
Member

This would be good to have!

With #1323 in mind, this should use Cargo flags to only bring in the dependencies and code if the crate user wants the behavior. In other words, if someone does not want to compress the payload, they shouldn't have to download and compile the gzip crate. 😄

@matthewkmayer
Copy link
Member

Done in #1615 . Thanks @plazma-prizma ! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants